Allow disabling automatic self-update with env#31
Merged
kevinmcconnell merged 1 commit intomainfrom Mar 31, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds an opt-out switch for ONCE’s background runner so operators can disable the automatic self-update behavior via an environment variable.
Changes:
- Skip self-update checks when
ONCE_NO_SELF_UPDATEis set. - Add
osimport to support environment-variable lookup.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+81
to
+83
| if os.Getenv("ONCE_NO_SELF_UPDATE") != "" { | ||
| return false | ||
| } |
There was a problem hiding this comment.
New behavior to disable self-update via ONCE_NO_SELF_UPDATE isn’t covered by tests. Since this branch returns before using ns/state, a small unit test can set the env var and assert checkSelfUpdate returns false (and does not require constructing a real namespace/state).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.