Skip to content

Add resource to the section in system.xml again #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2025
Merged

Add resource to the section in system.xml again #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "basecom/magento2-speculation-rules-toolbox",
"version": "0.9.1",
"version": "0.9.2",
"description": "Magento2 module to provide extensive functionality for speculation rules",
"type": "magento2-module",
"license": [
Expand Down
5 changes: 3 additions & 2 deletions etc/adminhtml/system.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
>
<label>Performance</label>
<tab>basecom</tab>
<resource>Basecom_SpeculationRulesToolbox::config</resource>
<group id="speculation_rules_toolbox" translate="label" type="text" sortOrder="10"
showInDefault="1"
showInWebsite="1"
Expand Down Expand Up @@ -165,7 +166,7 @@
<label>Banned terms</label>
<comment>
<![CDATA[
URLs containing these terms will not be considered for preloading.
URLs containing these terms will not be considered for preloading. Applies to all subsequent preloads, except for rules defined in your own custom script.
]]>
</comment>
<tooltip>
Expand Down Expand Up @@ -659,7 +660,7 @@
<comment>The CSS-selector used for targeting the elements to be preloaded.</comment>
<tooltip>
<![CDATA[Good to know:<br>You can use <b>any</b> CSS-selector. The underlying code will check, if the matched elements are already a-tags (using document.querySelectorAll().<br><br>If they are not all a-tags,
the element is loaded via document.querySelector() and all of its child a-tags are matched. This is especially useful when you have already e.g. a specific container you would like to target.]]>
the element is loaded via document.querySelector() and all of its child a-tags are matched. This is especially useful when you already have e.g. a specific container you would like to target.]]>
</tooltip>
<depends>
<field id="dynamic_targets_enabled">1</field>
Expand Down