Fix deal creation with hash as argument#39
Merged
Conversation
Fix a bug introduced in 78112f2 where it was impossible to create a deal by just passing a hash to `create`. `sanitize` method was expecting passed argument to respond to value which in case of hash was failing.
| it "returns instance of Deal class" do | ||
| @deal = build(:deal) | ||
| expect(client.deals.create(@deal)).to be_instance_of BaseCRM::Deal | ||
| deal = build(:deal) |
Contributor
There was a problem hiding this comment.
Don't you think that this change is not significant enough to add chaos to history of this file?
Contributor
Author
There was a problem hiding this comment.
Yes it is not significant.
But I just added a spec below that follows the same convention and I don't want to assign stuff to instance variable cause it does not make sense here (and adds confusion since you start wondering whether this variable is used somewhere else). So I went for local variable and changed this spec so that both of them follow the same pattern.
Contributor
|
Other than this, looks got to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a bug introduced in 78112f2 where it was impossible to create a deal
by just passing a hash to
create.sanitizemethod was expectingpassed argument to respond to value which in case of hash was failing.