Expose file section inspection helpers#124
Merged
Merged
Conversation
codeforester
added a commit
to basefoundry/base
that referenced
this pull request
Jul 7, 2026
## Summary - Replace `update_profile.sh`'s local marker-count and section-content temp-file comparison with shared `base-bash-libs` file section helpers. - Add an import capability check for `file_section_exists` and `file_section_needs_update` so older helper checkouts fail clearly. - Pin CI to `base-bash-libs` commit `424ef9fe61bc8a462ba9980ea63b38dd202ec242`, which landed the companion helper PR. Companion helper PR: basefoundry/base-bash-libs#124. Fixes #1492. ## Validation - RED: `env BASE_BASH_LIBS_DIR=/Users/rameshhp/work/base-bash-libs/lib/bash bats --filter "shared file section helper" cli/bash/commands/basectl/tests/update-profile.bats` failed before implementation because the shared helper stubs were not called. - PASS: `env BASE_BASH_LIBS_DIR=/Users/rameshhp/work/base-bash-libs/lib/bash bats --filter "shared file section helper" cli/bash/commands/basectl/tests/update-profile.bats` - PASS: `env BASE_BASH_LIBS_DIR=/Users/rameshhp/work/base-bash-libs/lib/bash bats cli/bash/commands/basectl/tests/update-profile.bats` - PASS: `bash -n cli/bash/commands/basectl/subcommands/update_profile.sh cli/bash/commands/basectl/tests/update-profile.bats` - PASS: `shellcheck -S warning cli/bash/commands/basectl/subcommands/update_profile.sh cli/bash/commands/basectl/tests/update-profile.bats` - PASS: `env PYTHONPATH=lib/python:cli/python $HOME/.base.d/base/.venv/bin/python -m pytest tests/test_github_workflows.py` - PASS: `git diff --check` - PASS: `env -u BASE_HOME BASE_BASH_LIBS_DIR=/Users/rameshhp/work/base-bash-libs/lib/bash BASE_CACHE_DIR=/private/tmp/base-pr-train-1492 ./bin/base-test`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
file_section_existsandfile_section_needs_updatehelpers tolib/bash/file/lib_file.sh.update_file_section, including asymmetric and misordered marker errors.Fixes #101.
Validation
bats --filter "file_section" lib/bash/file/tests/lib_file.batsfailed before implementation because the helpers were missing.bats --filter "file_section" lib/bash/file/tests/lib_file.batsbats lib/bash/file/tests/lib_file.batsbash -n lib/bash/file/lib_file.sh lib/bash/file/tests/lib_file.batsshellcheck -S warning lib/bash/file/lib_file.sh lib/bash/file/tests/lib_file.batsgit diff --check./tests/validate.sh