Refactor dev profile helpers#1483
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
base_dev.profiles.base_dev.enginere-export compatibility for existing callers.Closes #1464
Validation
PYTHONPATH=lib/python:cli/python $HOME/.base.d/base/.venv/bin/python -m pytest cli/python/base_dev/tests/test_engine.py::DevManifestTests::test_engine_reexports_profile_helpers -qPYTHONPATH=lib/python:cli/python $HOME/.base.d/base/.venv/bin/python -m pytest cli/python/base_dev/tests/test_engine.py -qPYTHONPATH=lib/python:cli/python $HOME/.base.d/base/.venv/bin/python -m pytest cli/python/base_dev/tests -qPYTHONPATH=lib/python:cli/python $HOME/.base.d/base/.venv/bin/python -m pylint cli/python/base_dev/engine.py cli/python/base_dev/profiles.py cli/python/base_dev/tests/test_engine.pyPYTHONPATH=lib/python:cli/python $HOME/.base.d/base/.venv/bin/python -m compileall -q cli/python/base_dev/engine.py cli/python/base_dev/profiles.py cli/python/base_dev/tests/test_engine.pygit diff --checkenv BASE_BASH_LIBS_DIR=/Users/rameshhp/work/base-bash-libs/lib/bash BASE_CACHE_DIR=/private/tmp/base-1464-dev-smoke bin/basectl setup --profile dev --dry-runNote
basectl check base --profile dev --format jsonreached the refactored profile code but was not used as the passing smoke because this sandbox cannot write/Users/rameshhp/.base.d/base/checks/last.json.tmp, and this host is missing some dev profile Homebrew tools.