Skip to content

HTML5 표준 준수하도록 수정 #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
simnalamburt merged 2 commits into from
Dec 21, 2016
Merged

HTML5 표준 준수하도록 수정 #3

simnalamburt merged 2 commits into from
Dec 21, 2016

Conversation

@simnalamburt
Copy link
Member

@simnalamburt simnalamburt commented Dec 21, 2016

<table> 태그의 border 어트리뷰트는 HTML5 스펙에서 제외되었습니다. 똑같이 생긴 CSS 코드로 대체합니다.


@@ -3,6 +3,10 @@
 	<head>
 		<meta charset="utf-8">
 		<title>BaseHangul</title>
+		<style>
+			table.border { border: 1px outset gray; }
+			table.border th, td { border: 1px inset gray; }
+		</style>
 	</head>
 	<body>
 		<h1>BaseHangul 1.1</h1>
 @@ -15,7 +19,7 @@
 		<p>KS C 5601 조합 중 사전순으로 앞에서부터 1028개의 조합만을 사용합니다. &quot;흐&quot;의 경우 범위 밖에 있습니다만, padding 문자로 사용됩니다.</p>
 		<h2>예제</h2>
 		<h3>예제 1: 5바이트를 채운 경우</h3>
-		<table border="1">
+		<table class=border>
 			<tr><th>바이트 문자</th><th colspan="8">1 (49)</th><th colspan="8">2 (50)</th><th colspan="8">3 (51)</th><th colspan="8">a (97)</th><th colspan="8">b (98)</th></tr>
 			<tr><th>비트 값</th>
 				<td>0</td><td>0</td><td>1</td><td>1</td><td>0</td><td>0</td><td>0</td><td>1</td>

@simnalamburt
Add a simple editorconfig file
001f7df 
EditorConfig helps developers define and maintain consistent coding
styles between different editors and IDEs.

Reference:
  http://editorconfig.org
@simnalamburt
Remove the usage of 'border' attribute of <table> tag
6dc7537 
The border attribute on the table element is obsolete. We must use CSS
instead. This commit makes index.html as Vvalid HTML5.

Reference:
  https://html5.validator.nu
  https://developer.mozilla.org/en-US/docs/Web/HTML/Element/table#attr-border
@simnalamburt simnalamburt merged commit 9a1c5b4 into master Dec 21, 2016
@simnalamburt simnalamburt deleted the html5 branch December 21, 2016 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koreapyj koreapyj Awaiting requested review from koreapyj

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@simnalamburt