Correct backgrounds in "keepDoublePages" output#199
Merged
AnEnglishmanInNorway merged 2 commits intobash0:masterfrom Feb 25, 2025
Merged
Correct backgrounds in "keepDoublePages" output#199AnEnglishmanInNorway merged 2 commits intobash0:masterfrom
AnEnglishmanInNorway merged 2 commits intobash0:masterfrom
Conversation
I have not yet run all the other tests to verify that I have not broken them. Next step
reset standard startup file for all tests keep pdf outputs as examples for backgrounds and clipart color replacement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this should close issue #198. I have made one decision which might possibly be different from the original, namely that the "inside cover" pages (the ones which are forced blank by the album editor and which come out white in a printed album) now come out in the same colour as the cover. Personally I think this is preferable in a PDF which is either for screen display or for private printing. That isn't quite what #198 suggested, but I'm hoping it's good enough. The code around this issue is in any event a little clearer.