Skip to content

Custom strings + improvements round#12

Merged
DannyBen merged 6 commits intomasterfrom
custom-strings
Nov 21, 2019
Merged

Custom strings + improvements round#12
DannyBen merged 6 commits intomasterfrom
custom-strings

Conversation

@DannyBen
Copy link
Copy Markdown
Member

@DannyBen DannyBen commented Nov 20, 2019

This started as a custom strings PR and evolved a little, so:

Improvements:

  • Extract all hardcoded strings to a locale-like config, customizable by the user - closes Make all hard coded strings configurable #5
  • Add custom-strings example
  • Change many bash echo to echo -e to allow the user to apply newlines and more
  • Add bashly add strings command, which will copy the strings config to the user space. This command will be the home for additional goodies that can be added to the project.
  • Extracted base command to a base class
  • Add AssetHelper module, to help replace all those File.expand_path to find things we need to copy.
  • Improve integration tests by disabling leeway diff unless we are on CI.

Todo:

  • Back to 100% coverage

@DannyBen DannyBen changed the title Improvements round Custom strings + improvements round Nov 21, 2019
@DannyBen DannyBen merged commit 2ffe260 into master Nov 21, 2019
@DannyBen DannyBen deleted the custom-strings branch November 21, 2019 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make all hard coded strings configurable

1 participant