Skip to content

Resolve ruby warnings #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 11, 2020
Merged

Resolve ruby warnings #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a324086
resolve ruby warnings
DannyBen Jan 11, 2020
4e2da02
undo ERB deprecation fix for Ruby < 2.6
DannyBen Jan 11, 2020
08ab912
fix renderable erb
DannyBen Jan 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/bashly/concerns/renderable.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ module Bashly
module Renderable
def render(view)
template = File.read view_path(view)
# TODO: This new format is only supported in Ruby >= 2.6
# So for now, we keep the old deprecated syntax
# ERB.new(template, trim_mode: '%-').result(binding)
ERB.new(template, nil, '%-').result(binding)
end

Expand Down
2 changes: 1 addition & 1 deletion lib/bashly/models/command.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def commands
return [] unless options["commands"]
options["commands"].map do |options|
options['parents'] = parents + [name]
command = Command.new options
Command.new options
end
end

Expand Down