Skip to content

Fix local variables leaking from internal functions #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 7, 2025
Merged

Fix local variables leaking from internal functions #682

merged 2 commits into from
Nov 7, 2025

Conversation

@DannyBen
Copy link
Member

@DannyBen DannyBen commented Nov 7, 2025 •
edited
Loading

cc #681

  • Declare key as local in parse_requirements
  • Declare k as local in inspect_args
  • Add fixture/workspace spec for the two cases

@DannyBen DannyBen added this to the 1.3.4 milestone Nov 7, 2025
@DannyBen DannyBen merged commit efe753a into master Nov 7, 2025
9 of 11 checks passed
@DannyBen DannyBen deleted the fix/local-var-leakage branch November 7, 2025 15:18
@DannyBen DannyBen mentioned this pull request Nov 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.3.4

Development

Successfully merging this pull request may close these issues.

2 participants

@DannyBen