-
Notifications
You must be signed in to change notification settings - Fork 4
Allow using colon, semicolon and equal sign in completions #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
kronn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I need to add these approvals to my setup for scripts, looks really neat.
Changewise, I like that the change is sensibly small, local and reverted after its use.
rspec_approvals is a massive time saver for my tests, even more so in command line utilities. I will merge. Release will be coming later this week (you can use the edge in the meantime). |
|
It seems like the locally set env-var does not work as intended. With the generated script, I did not get the intended completion-behaviour. Maybe hold off on a release, I'd like to try to fix this today or tomorrow. |
|
You are right. I think that disabling it broke it.
EDIT: Does not work. |
|
npm had a similar problem: npm/npm@d7271b8 I thought that the setting inside the function would be the elegant and correct solution. That's what I get for thinking, I guess... |
I see that they reverted? There must be a way to change this temporarily - did you follow the npm thread to see if they solved it in a different way? Or did they just revert and left it unsolved? I was unable to get any better solutions from any of the chat AIs. |
|
They reverted the way with the env-var, not their custom parsing: https://github.com/npm/cli/blob/latest/lib/utils/completion.sh I'll try and see if I can get it to work similarly. |
|
Should I revert this PR, or are you trying to make it work? |
|
Both. :-) If I get to a solution, I'll send a PR. |
Raised and discussed in #66
This PR temporarily (locally) removes three characters from the list of word break characters: colon, semicolon, equal sign.