Remove extraneous 'thrift' dependency#125
Merged
slfritchie merged 1 commit intobasho:masterfrom Apr 23, 2014
Merged
Conversation
Contributor
|
+1, thanks, sorry about the slow review! |
slfritchie
added a commit
that referenced
this pull request
Apr 23, 2014
Remove extraneous 'thrift' dependency
Contributor
Author
|
Lovely, thanks @slfritchie ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
thriftdependency was introduced in b45e4d0 but I removed theerlcassadependency in 80a802b.Not making this change could actually cause
basho_bench_driver_cassandra.erlto break if the code path search order is ever changed as boththriftandcasbenchinclude athrift_client.erlmodule with different implementations. It just happens thatcasbench's one is actually used and is first on the path.