Skip to content

Make updates to key generators and example config files#135

Merged
slfritchie merged 1 commit intomasterfrom
slf-new-generators
Jul 28, 2014
Merged

Make updates to key generators and example config files#135
slfritchie merged 1 commit intomasterfrom
slf-new-generators

Conversation

@slfritchie
Copy link
Copy Markdown
Contributor

  • Change most example config files to use partitioned_sequential_int
    instead of sequential_int. The latter is usually not what people
    want: each load generator uses the same overlapping set of sequential
    integers. Especially for data setup/prepopulation use, you really
    want each concurrent worker to operate in keys unique from all of
    the other worker, i.e., GO FAST and do not repeat the work that some
    other worker has already done.
  • Remove the deprecated int_to_bin generator. Everyone should be using
    int_to_bin_bigendian or int_to_big_littleendian now.
  • Add {int_to_bin_bigendian, Bits} and {int_to_bin_littleendian, Bits}
    generators, to avoid the otherwise-hard-coded limitation of 32 bits
    worth of output.
  • Add the {crypto_hash, Type} generator. Valid types are:
    Type == md4; Type == md5; Type == ripemd160; Type == sha; Type == sha224;
    Type == sha256; Type == sha384; Type == sha512 ->
  • Bump the version number to 0.9 in the OTP app file.

cc: @reiddraper @ksauzz @kuenishi @shino

* Change most example config files to use partitioned_sequential_int
  instead of sequential_int.  The latter is usually not what people
  want: each load generator uses the same overlapping set of sequential
  integers.  Especially for data setup/prepopulation use, you really
  want each concurrent worker to operate in keys unique from all of
  the other worker, i.e., GO FAST and do not repeat the work that some
  other worker has already done.

* Remove the deprecated int_to_bin generator.  Everyone should be using
  int_to_bin_bigendian or int_to_big_littleendian now.

* Add {int_to_bin_bigendian, Bits} and {int_to_bin_littleendian, Bits}
  generators, to avoid the otherwise-hard-coded limitation of 32 bits
  worth of output.

* Add the {crypto_hash, Type} generator.  Valid types are:
       Type == md4; Type == md5; Type == ripemd160; Type == sha; Type == sha224;
       Type == sha256; Type == sha384; Type == sha512 ->

* Bump the version number to 0.9 in the OTP app file.
@reiddraper
Copy link
Copy Markdown

Thanks! Any thoughts on either warnings, or setting the rng_seed to now? Maybe partitioned seq int solves this, but it was surprising to me to run multiple instances of b_b and get the same exact keys generated from each one. Ditto running a benchmark again with what I thought was a really large keyspace, and doing a bunch of updates instead of unique PUTs.

@slfritchie
Copy link
Copy Markdown
Contributor Author

I'd be fine with a PR to change it. TBH, defaulting to the same seed is a
feature in the "repeatable" test direction. Changing it to default to a
random seed is fine by me, but because it'd cause a big change in behavior,
separating it out and adding warnings & bells & whistles seems advisable?

@reiddraper
Copy link
Copy Markdown

TBH, defaulting to the same seed is a
feature in the "repeatable" test direction.

Agree, and that's why I'm kind of conflicted about it as well. Let's get this PR merged in, and we can tackle this other issue separately. Since it should probably go in another PR anyway.

@reiddraper
Copy link
Copy Markdown

+1 to merge.

slfritchie added a commit that referenced this pull request Jul 28, 2014
Make updates to key generators and example config files
@slfritchie slfritchie merged commit ec3a4ba into master Jul 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants