a proxy driver to benchmark remote system#193
Merged
slfritchie merged 3 commits intobasho:masterfrom Dec 7, 2015
Merged
Conversation
Contributor
There was a problem hiding this comment.
Hi, sorry about the delay for review. I'm a bit curious about the reason for choosing a random actor vs. round-robin assignment based on the Id number.
Contributor
Author
There was a problem hiding this comment.
You are absolutely right! Round-robin allocation is cleaner and gives better way to control number of workers vs number of "remote" processes.
There was not any reason why random selection was done in original version. I've made changes based on your suggestion.
Contributor
|
Many thanks! I'll merge this PR today. |
slfritchie
added a commit
that referenced
this pull request
Dec 7, 2015
a proxy driver to benchmark remote system
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A typical benchmark scenario is that Basho Bench spawn Erlang VM and executes the driver inside. However, there is needs to catch performance metrics from an application executed remotely within dedicated environment (e.g. probe performance from live system; benchmark an application inside C or Java node, etc).