Conversation
Introduce the option to use now() to initialize your rng.
To use, add the following line to your bb config file:
{rng_seed, now}.
Contributor
|
@evanmcc What if that config key is undefined? Shouldn't we just use |
Contributor
Author
|
that config key is always defined, see basho_bench.app.src: {env, [
%%
%% Mode of load generation:
%% max - Generate as many requests as possible per worker
%% {rate, Rate} - Exp. distributed Mean reqs/sec
%%
{mode, {rate, 5}},
%% <snip>
%%
{rng_seed, {42, 23, 12}}
]} |
Contributor
Author
|
What about if I moved the definition from the env to the get call? |
Contributor
|
Works for me. There seems to be no good reason to have that statically defined. |
why someone might want to use a more random seed.
Contributor
Author
|
updated. I think that since it's currently statically defined, I'd like to leave it as is to avoid breaking any currently existing code that relies on that functionality. |
Contributor
|
+1 to merge, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes you want randomness more than reproducability.
Introduce the option to use now() to initialize your rng.
To use, add the following line to your bb config file:
{rng_seed, now}.