verify seq_int resume value is not out of bounds#68
Merged
slfritchie merged 1 commit intobasho:masterfrom Apr 9, 2013
joecaswell:jhc-resumecheck
Merged
verify seq_int resume value is not out of bounds#68slfritchie merged 1 commit intobasho:masterfrom joecaswell:jhc-resumecheck
slfritchie merged 1 commit intobasho:masterfrom
joecaswell:jhc-resumecheck
Conversation
Contributor
|
sorry, should have +1'd this a while ago. |
slfritchie
added a commit
that referenced
this pull request
Apr 9, 2013
verify seq_int resume value is not out of bounds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a previous run left a resume file for a sequntial_int_generator that contains a value that is greater than MaxValue, the terminating condition will never be met.
When loading the resume value, if it is greater than MaxValue, start over from 0 and warn the user.