Skip to content

add delete support for basho_bench_driver_http_raw #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vinoski merged 1 commit into from
Mar 26, 2013
+21 −1
Merged

add delete support for basho_bench_driver_http_raw #71

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion src/basho_bench_driver_http_raw.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
%%
%% basho_bench: Benchmarking Suite
%%
%% Copyright (c) 2009-2010 Basho Techonologies
%% Copyright (c) 2009-2013 Basho Techonologies
%%
%% This file is provided to you under the Apache License,
%% Version 2.0 (the "License"); you may not use this file
Expand Down Expand Up @@ -212,6 +212,15 @@ run(put, KeyGen, ValueGen, State) ->
{error, Reason} ->
{error, Reason, S2}
end;
run(delete, KeyGen, _ValueGen, State) ->
{NextUrl, S2} = next_url(State),
Url = url(NextUrl, KeyGen, State#state.path_params),
case do_delete(Url, [State#state.client_id]) of
ok ->
{ok, S2};
{error, Reason} ->
{error, Reason, S2}
end;

run(put_file, _, _, #state{files=[]}) ->
throw({stop, empty_keygen});
Expand Down Expand Up @@ -384,6 +393,17 @@ do_post(Url, Headers, ValueGen) ->
{error, Reason}
end.

do_delete(Url, Headers) ->
case send_request(Url, Headers, delete, [], []) of
{ok, "204", _Header, _Body} ->
ok;
{ok, "404", _Header, _Body} ->
ok;
{ok, Code, _Header, _Body} ->
{error, {http_error, Code}};
{error, Reason} ->
{error, Reason}
end.

connect(Url) ->
case erlang:get({ibrowse_pid, Url#url.host}) of
Expand Down