Skip to content

Add riak_cs support (imported from riak_cs/bench)#78

Merged
shino merged 1 commit intobasho:masterfrom
sogabe:riak_cs_2
Apr 15, 2013
Merged

Add riak_cs support (imported from riak_cs/bench)#78
shino merged 1 commit intobasho:masterfrom
sogabe:riak_cs_2

Conversation

@sogabe
Copy link
Copy Markdown
Contributor

@sogabe sogabe commented Apr 4, 2013

This patch depends on stanchion_auth in velvet. Previous pull-req was copied stanchion_auth.hrl. to the repository.

Comment thread examples/cs.config.sample Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good eye on the typo (ibrowse_block_size in original one in cs repo) :)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, one extra comma character after ibrowse_block_size

@shino
Copy link
Copy Markdown
Contributor

shino commented Apr 14, 2013

Sorry for late reply.

Looks perfect expect one tiny point I commented above.
I will merge if it is corrected.

Thank you very much for contribution!

@ghost ghost assigned shino Apr 14, 2013
@sogabe
Copy link
Copy Markdown
Contributor Author

sogabe commented Apr 15, 2013

Thanks for your comment. I fixed an typo in examples/cs.config.sample.

shino pushed a commit that referenced this pull request Apr 15, 2013
Add riak_cs support (imported from riak_cs/bench)
@shino shino merged commit 85b35fe into basho:master Apr 15, 2013
@shino
Copy link
Copy Markdown
Contributor

shino commented Apr 15, 2013

@sogabe -san:
Merged. Thanks a lot!

@slfritchie
Copy link
Copy Markdown
Contributor

Mina-san, thank you for your work and review. Would it be possible to create a quick PR to remove the 'bench' subdir from the riak_cs repo? It does not make sense to have two copies of the driver.

@shino
Copy link
Copy Markdown
Contributor

shino commented Apr 15, 2013

@slfritchie Yes. I will do it right now after one more pull request to basho_bench which add +K flag to rebar.config.

@shino
Copy link
Copy Markdown
Contributor

shino commented Apr 15, 2013

FYI: basho/riak_cs#536

shino pushed a commit to basho/riak_cs_multibag that referenced this pull request Apr 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants