Fix FreeBSD package compilation#24
Merged
jaredmorrow merged 3 commits intomasterfrom Jun 13, 2012
Merged
Conversation
When doing a `make package` from toplevel riak, BSD's make was pulling in random characters as targets when the specific make target was not specified. I can't find any reason or documentation on why this would happen, but adding the `js` target fixed things.
Contributor
|
Build fine. Excellent find! |
jaredmorrow
added a commit
that referenced
this pull request
Jun 13, 2012
Fix FreeBSD package compilation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building from Riak toplevel using the
make packagecommand, flags were slipping into theMAKEFLAGSvariable causing problems in erlang_js. This simply empties out that environmental variable before running anymakecommands.