Lock spidermonkey_drv.so in memory so NSPR thread cleanup code runs.#25
Merged
jonmeredith merged 1 commit intomasterfrom Jun 18, 2012
Merged
Lock spidermonkey_drv.so in memory so NSPR thread cleanup code runs.#25jonmeredith merged 1 commit intomasterfrom
jonmeredith merged 1 commit intomasterfrom
Conversation
Fixes SEGV under R15B
Contributor
|
+1, bug be gone, looks like an appropriate use for |
jonmeredith
added a commit
that referenced
this pull request
Jun 18, 2012
Lock spidermonkey_drv.so in memory so NSPR thread cleanup code runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes SEGV under R15B.
Eventually tracked down using valgrind-build of beam and doing some digging.
Was erroring with
which was in the memory range that erlang_js_drv.so used to occupy. Info gathered before the breakpoint.
The address above was mapped to
which is some thread cleanup code in NSPR.
Something must have changed about the order of library unloading for the R15 shutdown sequence as we haven't seen this on R14 or before to my knowledge.
The solution is to make the driver permanent and lock the shared object in memory with
driver_lock_driver(port)