Skip to content

Conversation

romuloceccon
Copy link
Contributor

Argument verbose to nametuple constructor was deprecated in Python 3.3, and was removed in Python 3.7.

This PR fixes the issue with Python 3.7 where trying to import riak raises an exception with message TypeError: namedtuple() got an unexpected keyword argument 'verbose'.

Argument `verbose` to nametuple constructor was deprecated in Python
3.3, and was removed in Python 3.7.
@ghost
Copy link

ghost commented Mar 19, 2018

Seems to have failed travis check - I'm going to run it on my travis fork

@ghost
Copy link

ghost commented Mar 19, 2018

Failing because the code formatting check utility (flake8) behavior has become more strict.

See this issue for extended (yawn) debate as to what does or doesn't constitute legitimate code - PyCQA/pycodestyle#703

Any of our builds will now fail due to this change - until we get permanent maintainers involved - I suggest code is better than beautifully formatted flake8 compliant non-code.

I recommend we comment out the following line of travis.yml change to skip the flake8 testing.

flake8 --exclude=riak/pb riak *.py

I've done so and now have passing builds

@martincox any thoughts ?

@ghost
Copy link

ghost commented Mar 19, 2018

Actually, we can do it a little bit cleaner - I've disabled those two specific style checks on the following PR #531 - if it passes we can merge it in first.

@nickkeers
Copy link
Contributor

Thanks @romuloceccon - I'll get it merged as soon as we can get travis working!

@romuloceccon
Copy link
Contributor Author

You're welcome, @nickkeers. Travis will only work again with both this and #531 merged in. Let me know if you want me to rebase my branch over bryanhuntesl@patch-1 (it's currently based on master).

@nickkeers
Copy link
Contributor

@romuloceccon No worries, I'll just merge as it makes sense to me!

@nickkeers nickkeers merged commit 78e3c41 into basho:master Mar 20, 2018
@browniebroke browniebroke mentioned this pull request Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants