Skip to content

Conversation

@bkerley
Copy link
Contributor

@bkerley bkerley commented Aug 27, 2013

It's Happening

Refer to https://github.com/basho/yokozuna/wiki/Client-Test-Checklist

Schema Management / DDL

  • Create schema
  • Read schema
  • Create index
  • List indexes
  • Read index
  • Associate indexes with buckets

Queries / DML

@coderoshi
Copy link
Contributor

The generator code is missing RpbSearch messages, namely RpbSearchDoc, RpbSearchQueryReq, RpbSearchQueryResp

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The messages file needs a change from what protoc generates.

This message needs field replaced with properties.

class RpbSearchDoc
  repeated :fields, RpbPair, 1
end

to this

class RpbSearchDoc
  repeated :properties, RpbPair, 1
end

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I originally changed :fields to :properties because fields is a method defined by Beefcake::Message. Now that development is picking back up, maybe we could fix that in Beefcake?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed here ce4cad1

@seancribbs
Copy link
Contributor

Changes look good so far, but there's quite a bit missing in the integration specs. LMK when this is closer to ready.

bkerley added a commit that referenced this pull request Sep 19, 2013
@bkerley bkerley merged commit a8be8aa into master Sep 19, 2013
@bkerley bkerley added this to the 2.0.0 milestone Apr 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants