-
Notifications
You must be signed in to change notification settings - Fork 90
Riak 2 Feature: Yokozuna #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The generator code is missing RpbSearch messages, namely RpbSearchDoc, RpbSearchQueryReq, RpbSearchQueryResp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The messages file needs a change from what protoc generates.
This message needs field replaced with properties.
class RpbSearchDoc
repeated :fields, RpbPair, 1
end
to this
class RpbSearchDoc
repeated :properties, RpbPair, 1
end
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I originally changed :fields to :properties because fields is a method defined by Beefcake::Message. Now that development is picking back up, maybe we could fix that in Beefcake?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed here ce4cad1
|
Changes look good so far, but there's quite a bit missing in the integration specs. LMK when this is closer to ready. |
Refer to https://github.com/basho/yokozuna/wiki/Client-Test-Checklist
Schema Management / DDL
Queries / DML