-
Notifications
You must be signed in to change notification settings - Fork 90
Riak 2 Feature: Yokozuna #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
11a5b29
start yz integration specs
bkerley ac1140f
Use beefcake to generate the list of messages from riak_pb
bkerley 1d780d7
Generated message list
bkerley 840934a
Merge branch 'bk-beefcake-compiler' into bk-yokozuna
bkerley 18d81da
Add yz message codes
bkerley f17c66d
Add admin defs to pb backend and client
coderoshi 39acb98
generate riak_search protobuffs too
bkerley 7ce0689
Merge branch 'bk-beefcake-compiler' into bk-yokozuna
bkerley 633979f
Merge branch 'bk-yokozuna' of https://github.com/basho/riak-ruby-clie…
bkerley 9d0f694
Fix search message field name
coderoshi ce4cad1
Overlay search message
coderoshi 25b7816
Move yokozuna specs into bryans integration template
coderoshi d128421
kickoff incomplete utf8 test
coderoshi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -38,3 +38,4 @@ Gemfile.lock | |
| vendor/erlang | ||
| vendor/riak | ||
| .ruby-version | ||
| tmp | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
|
|
||
| end | ||
| end | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| require 'beefcake' | ||
|
|
||
| module Riak | ||
| class Client | ||
| # @private | ||
| class BeefcakeProtobuffsBackend |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| module Riak | ||
| class Client | ||
| # @private | ||
| class BeefcakeProtobuffsBackend | ||
| class RpbIndexReq | ||
| module IndexQueryType | ||
| EQ = 0 | ||
| RANGE = 1 | ||
| end | ||
| end | ||
|
|
||
| class RpbBucketProps | ||
|
|
||
| # "repeated" elements with zero items are indistinguishable | ||
| # from a nil, so we have to manage has_precommit/has_postcommit | ||
| # flags. | ||
| def precommit=(newval) | ||
| @precommit = newval | ||
| @has_precommit = !!newval | ||
| end | ||
|
|
||
| def has_precommit=(newval) | ||
| @has_precommit = newval | ||
| @precommit ||= [] if newval | ||
| end | ||
|
|
||
| def postcommit=(newval) | ||
| @postcommit = newval | ||
| @has_postcommit = !!newval | ||
| end | ||
|
|
||
| def has_postcommit=(newval) | ||
| @has_postcommit = newval | ||
| @postcommit ||= [] if newval | ||
| end | ||
| end | ||
|
|
||
| class RpbSearchDoc | ||
| # rebuild the fields instance method since the | ||
| # generated :fields field overwrote this | ||
| def fields | ||
| self.class.fields | ||
| end | ||
| repeated :properties, RpbPair, 1 | ||
| end | ||
|
|
||
| end | ||
| end | ||
| end |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The messages file needs a change from what protoc generates.
This message needs field replaced with properties.
to this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I originally changed
:fieldsto:propertiesbecausefieldsis a method defined byBeefcake::Message. Now that development is picking back up, maybe we could fix that in Beefcake?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed here ce4cad1