Description
The DEFAULT_IGNORE_PATTERNS set and create_default_bmignore() function maintain duplicate copies of the same patterns, violating the DRY principle.
Current Implementation
DEFAULT_IGNORE_PATTERNS (lines 10-57) maintains patterns as a Python setcreate_default_bmignore() (lines 80-140) writes the same patterns as a string
Proposed Solution
def create_default_bmignore() -> None:
patterns_text = "\n".join(sorted(DEFAULT_IGNORE_PATTERNS))
bmignore_path.write_text(f"# Basic Memory Ignore Patterns\n{patterns_text}\n")Impact
Minor maintenance burden, not critical but improves code maintainability.
File
src/basic_memory/ignore_utils.py
References
Description
The
DEFAULT_IGNORE_PATTERNSset andcreate_default_bmignore()function maintain duplicate copies of the same patterns, violating the DRY principle.Current Implementation
DEFAULT_IGNORE_PATTERNS(lines 10-57) maintains patterns as a Python setcreate_default_bmignore()(lines 80-140) writes the same patterns as a stringProposed Solution
Impact
Minor maintenance burden, not critical but improves code maintainability.
File
src/basic_memory/ignore_utils.pyReferences