[BUG] Note created outside of project

[phernandez]

File with folder path prefix "~" created outside of project

So what I think happened is this: When I told Claude to create the Test BiSync project, I did not specify a folder. So Claude chose "documents" for some reason and placed my new project in there (see screenshot below of my basic-memory-cloud-sync folder). And maybe for some reason the API or UI thinks that any folder in the root is a different project?

So, I told Claude to create the project. Claude chose to put the project in a "documents" folder.
So project is created in the cloud at "documents/test biysnc".

{'request': CallToolRequest(method='tools/call', params=CallToolRequestParams(meta=None, name='create_memory_project', arguments={'project_name': 'Test BiSync', 'project_path': '~/Documents/Test BiSync', 'set_default': True}), jsonrpc='2.0', id=5), 'response': CallToolResult(meta=None, content=[TextContent(type='text', text='''✓ Project \'Test BiSync\' added successfully

Project Details:
• Name: Test BiSync
• Path: ~/Documents/Test BiSync
• Set as default project

Project is now available for use in tool calls.
Use \'Test BiSync\' as the project parameter in MCP tool calls.
''', annotations=None, meta=None)], structuredContent={'result': '''✓ Project \'Test BiSync\' added successfully

Project Details:
• Name: Test BiSync
• Path: ~/Documents/Test BiSync
• Set as default project

Project is now available for use in tool calls.
Use \'Test BiSync\' as the project parameter in MCP tool calls.
'''}, isError=False)}

[claude]

Claude finished @phernandez's task —— View job • claude/issue-340-20251008-0103 • Create PR ➔

---

Bug fixed and ready for review ✓

Todo List:

• Analyze the issue and understand the bug
• Search for project creation and path handling code
• Identify root cause of ~ path expansion issue
• Search for where file paths are validated during note creation
• Triage with appropriate labels
• Determine fix complexity
• Implement fix
• Add labels to issue
• Commit and push changes
• Create pull request

Root Cause

The bug was in src/basic_memory/schemas/project_info.py at line 186:

@property
def home(self) -> Path:
    return Path(self.name)  # BUG: returned name instead of path

Impact

When creating notes via MCP tools, the write_note tool validates folder paths using validate_project_path(folder, project_path). The project_path comes from active_project.home, which was incorrectly returning the project name instead of the project path. This caused path validation to fail and notes to be created outside the project directory.

The Fix

Changed line 186 to: return Path(self.path)

This property is used across multiple MCP tools for path validation:

• write_note.py:128 - validates folder paths when creating notes
• read_note.py:87 - validates paths when reading notes
• read_content.py:210 - validates paths when reading content
• move_note.py:403 - validates paths when moving notes
• sync_status.py:238 - displays project path in status

Testing Recommendation

When testing this fix, verify that:

1. Projects created with paths like ~/Documents/Test work correctly
2. Notes can be created within the project using folder paths like documents or notes
3. Path validation correctly rejects traversal attempts like ../ or ~

---

|

[phernandez]

Root Cause Analysis

This issue had two related bugs:

Bug 1: ProjectItem.home returning name instead of path

The ProjectItem.home property was returning Path(self.name) instead of Path(self.path).expanduser(). This caused path validation to use the project name (e.g., "Test BiSync") as the base path instead of the actual project path.

Bug 2: Cloud mode creating nested paths

When project_root was set (cloud mode), the system was sanitizing the user's provided path and creating nested directory structures:

• User creates: name="Test BiSync", path="~/Documents/Test BiSync"
• Cloud created: /app/data/documents/test bisync (nested)

This caused bisync auto-discovery to find the documents/ subdirectory and incorrectly register it as a new project.

Solution

Fixed in commits:

• 9e9607b5 - Fixed ProjectItem.home to return Path(self.path).expanduser()
• c8ad0741 - Changed cloud mode to use sanitized project name instead of user path

Cloud mode now:

• Ignores user's provided path completely
• Uses sanitized project name: generate_permalink(name)
• Creates flat structure: /app/data/test-bi-sync

This ensures bisync can properly match projects by their sanitized names without creating duplicates for subdirectories.

Testing

• Added test for ProjectItem.home expanduser functionality
• Updated all cloud mode tests to verify new flat structure behavior
• All project service tests passing

Branch: claude/issue-340-20251008-0103