fix: enhance character conflict detection and error handling for sync operations #201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… operations - Add pre-move validation to detect file path conflicts before database operations - Implement comprehensive conflict detection for case sensitivity, Unicode, and character encoding differences - Add utility functions for file path normalization and conflict analysis - Enhance error messages with specific guidance for different conflict types - Add comprehensive test coverage for character conflict scenarios - Create user documentation for character handling best practices This resolves the IntegrityError "UNIQUE constraint failed: entity.file_path, entity.project_id" by detecting conflicts proactively and providing clear resolution guidance. Addresses user feedback on: - Hyphens/dashes conflicts between filenames and generated permalinks - Case sensitivity issues on macOS (Finance/ vs finance/) - Forward slash handling in file paths and metadata - Enhanced validation and error messaging Co-authored-by: Paul Hernandez <phernandez@users.noreply.github.com>
jope-bm
approved these changes
Jul 29, 2025
| conflicts = [] | ||
|
|
||
| # Get all existing file paths | ||
| all_entities = await self.repository.find_all() |
Contributor
There was a problem hiding this comment.
I wonder how performant this will be for large numbers of entities
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #169
This PR addresses the character-related sync issues reported by users, specifically the IntegrityError "UNIQUE constraint failed: entity.file_path, entity.project_id".
Changes
Issues Addressed
Generated with Claude Code