Skip to content

fix(cli): point bm cloud setup hint at bm cloud sync-setup#780

Merged
groksrc merged 1 commit intomainfrom
fix/cloud-sync-setup-hint
May 2, 2026
Merged

fix(cli): point bm cloud setup hint at bm cloud sync-setup#780
groksrc merged 1 commit intomainfrom
fix/cloud-sync-setup-hint

Conversation

@groksrc
Copy link
Copy Markdown
Member

@groksrc groksrc commented May 2, 2026

Summary

  • bm cloud setup printed bm project sync-setup ... in its "Next steps", but the command is registered under the cloud Typer app (@cloud_app.command("sync-setup") in cli/commands/cloud/project_sync.py:275). Following the hint produced No such command 'sync-setup'.
  • Replaced the bad command in the post-setup output (cli/commands/cloud/core_commands.py:182) and in docs/cloud-cli.md (4 occurrences) with the correct bm cloud sync-setup.

Closes #779

Test plan

  • bm cloud setup "Next steps" output now shows bm cloud sync-setup <name> <path>
  • bm cloud sync-setup --help resolves (sanity check the command path is unchanged)
  • docs/cloud-cli.md no longer references bm project sync-setup

🤖 Generated with Claude Code

The post-setup "Next steps" output and cloud CLI docs instructed users
to run `bm project sync-setup`, but the command is registered under the
`cloud` Typer app as `bm cloud sync-setup`. Following the hint produced
"No such command 'sync-setup'".

Closes #779

Signed-off-by: Drew Cain <groksrc@gmail.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 2, 2026

Claude finished @groksrc's task in 1m 17s —— View job


Code Review

  • Gather context and read changed files
  • Verify the fix is correct
  • Run through team checklist

Summary: This is a clean, minimal, correct fix. The command sync-setup is registered under @cloud_app.command("sync-setup") at cli/commands/cloud/project_sync.py:275, confirming bm cloud sync-setup is the correct invocation. No remaining incorrect bm project sync-setup references were found after the fix.

Team Checklist

Code Quality & Standards

  • Follows Basic Memory's coding conventions — pure string/doc change, no logic altered
  • Line length — changed line at core_commands.py:182 is well within 100 chars
  • No commented-out code blocks

Testing & Documentation

  • No new functions/logic — no tests required for a hint text fix
  • Documentation updated — all 4 occurrences in docs/cloud-cli.md corrected
  • CLAUDE.md update not required

Basic Memory Architecture

  • N/A — no architectural changes

Security & Performance

  • No concerns

Compatibility

  • No emojis or unicode added
  • No Windows path concerns

Verdict: LGTM ✓ — The root cause (wrong namespace in the hint) is correctly diagnosed and fully fixed in both the CLI output and the docs. The PR is appropriately scoped with no unrelated changes.

Note (out of scope for this PR): While reviewing, I noticed docs/cloud-cli.md also references bm project sync (e.g. lines 294, 303, 730) — but sync is also registered under @cloud_app.command("sync") at project_sync.py:92. Worth a follow-up issue to check if those references also need correcting.

@groksrc groksrc merged commit 5ccf433 into main May 2, 2026
25 checks passed
@groksrc groksrc deleted the fix/cloud-sync-setup-hint branch May 2, 2026 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bm cloud setup points users to non-existent 'bm project sync-setup' command

1 participant