Skip to content

Conversation

@MrTelanie
Copy link
Member

first I created index.d.ts manually
then i tried to find out in which folder i have to place it
then i realised unbuild already creates d.ts files for every file

lucky for us, typescript is compatible with jsdoc
https://www.typescriptlang.org/docs/handbook/jsdoc-supported-types.html

so the code changes are really tiny

@MrTelanie MrTelanie requested a review from ThornWalli March 9, 2025 10:36
@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 9, 2025

Open in Stackblitz

npm i https://pkg.pr.new/basics/vector/@js-basics/vector@545

commit: 4c54924

@MrTelanie
Copy link
Member Author

@ThornWalli
is main as target branch ok?

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@MrTelanie MrTelanie merged commit f63bcf9 into main Mar 11, 2025
7 of 8 checks passed
@MrTelanie MrTelanie deleted the feature/factory-types branch March 11, 2025 08:25
@github-actions
Copy link

🎉 This PR is included in version 2.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants