V2

[komtcho]

No description provided.

[komtcho]

/oc review

[opencode-agent]

Code Review: V2

This is a major version bump with breaking changes. Here's my analysis:

Breaking Changes

1. PHP 8.3 required (was 8.1/8.2) - composer.json:5
2. Laravel 11+ required (was 10/11) - composer.json:6
3. Filament removed - No admin panel resources anymore
4. Coupons removed - Entire coupon system deleted (src/Calculate/CouponCalculate.php, src/Contracts/ICoupon.php)
5. Order functionality removed - src/Models/Order.php, src/Traits/HasOrder.php deleted
6. API change: initCart()/openCart() → CartManagement::make() - tests/Feature/TotalsTest.php:62

New Features

1. Flexible totals system - applyAddition()/applyDiscount() with optional keys - src/Services/TotalService.php:96-140
2. HasManageTotals interface - Allows products to manage their own totals - src/Contracts/HasManageTotals.php
3. AmountsResource - New resource for managing multiple additions/discounts - src/Services/Resources/AmountsResource.php

Potential Issues

1. README outdated - Still mentions "coupons" in line 3 despite removal
2. Migration deleted but still referenced - 2024_08_19_142245_create_basketin_cart_orders_table.php deleted but the change isn't documented
3. Events removed - All basketin events were stripped of content (became empty)

Test Coverage

New tests added for additions/discounts system look comprehensive (lines 72-425 in TotalsTest.php).

Recommendation

This is a solid breaking change for V2. The removal of Filament makes the package lighter for API-only use cases. The new totals system is more flexible than the old coupon system. Consider updating the README to reflect the actual feature set.

opencode session  |  github run

[komtcho]

/oc review

[opencode-agent]

Code Review: V2

Summary

This is a solid V2 release with intentional breaking changes. The refactoring removes the Filament dependency (lighter for API-only use) and replaces the rigid coupon system with a flexible additions/discounts API.

Issues to Fix

1. README outdated - Line 3 still mentions "coupons" but they're removed:

   - Laravel cart library for e-commerce. Provides carts, quotes (line items), totals, coupons, custom fields, and order preparation with a clean API.
   + Laravel cart library for e-commerce. Provides carts, quotes (line items), totals, additions, discounts, and order preparation with a clean API.

2. Migration deleted - create_basketin_cart_orders_table.php removed but no upgrade guide. Consider adding a UPGRADE.md for users migrating from V1.

What's Good

• Clean totals API (TotalService.php:102-140) - Fluent applyAddition()/applyDiscount() with optional keys
• Type safety - PHP 8.3 requirement enables modern PHP features
• Test coverage - New additions/discounts functionality well-tested in TotalsTest.php

Breaking Changes Summary

Feature	V1	V2
PHP	8.1+	8.3+
Laravel	10/11	11/12
Admin	Filament	Removed
Coupons	Yes	Removed
Orders	Yes	Removed

Verdict

Approve once README is updated. Consider documenting the migration path from V1.

opencode session  |  github run

[komtcho]

/oc review

[opencode-agent]

Code Review: V2 (Updated)

Status

The README still has the outdated description from V1 - line 3 mentions "coupons" which were removed in this version.

Issues Still Present

1. README not updated - Line 3 still says "coupons" but they're removed in V2:

   Laravel cart library for e-commerce. Provides carts, quotes (line items), totals, coupons, custom fields, and order preparation with a clean API.
   

   Should be updated to mention "additions, discounts" instead of "coupons".

Previous Issues Now Resolved

• New totals API (applyAddition/applyDiscount) implemented correctly
• HasManageTotals interface added
• AmountsResource added
• Test coverage for new features in place

Breaking Changes Summary

Feature	V1	V2
PHP	8.1+	8.3+
Laravel	10/11	11+
Admin	Filament	Removed
Coupons	Yes	→ Additions/Discounts API
Orders	Yes	Removed

Verdict

Needs changes: Update README line 3 to reflect V2 feature set (replace "coupons" with "additions, discounts"). Everything else looks good.

opencode session  |  github run