Skip to content

Clean up macOS menu activity abstractions#551

Merged
basnijholt merged 1 commit into
mainfrom
codex/cleanup-menu-activity-abstractions
May 29, 2026
Merged

Clean up macOS menu activity abstractions#551
basnijholt merged 1 commit into
mainfrom
codex/cleanup-menu-activity-abstractions

Conversation

@basnijholt
Copy link
Copy Markdown
Owner

Summary

  • move menu activity priority/timing state into a dedicated MenuActivityTracker
  • replace duplicated submenu activity item/separator fields with MenuActivityStatusRow
  • add Swift coverage for tracker priority and command restoration behavior

Verification

  • swift build --package-path macos/AgentCLI
  • uv run pytest -q tests/test_macos_app.py
  • uv run pre-commit run --all-files
  • git diff --check

Note: local swift test --package-path macos/AgentCLI --enable-xctest links the test bundle but cannot execute here because this Command Line Tools install fails xcrun --sdk macosx --show-sdk-platform-path. CI macOS runners should execute the XCTest target.

@basnijholt basnijholt merged commit c0fc3c3 into main May 29, 2026
10 checks passed
@basnijholt basnijholt deleted the codex/cleanup-menu-activity-abstractions branch May 29, 2026 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant