VendorConfiguration: speed up collecting definition lines#8933
VendorConfiguration: speed up collecting definition lines#8933
Conversation
|
This change is |
| } | ||
| return IntStream.empty(); | ||
| }) | ||
| .distinct(); |
There was a problem hiding this comment.
Q: how much does this .distinct() matter. Having a hard time finding a benchmark that would have invoked it.
dhalperi
force-pushed
the
spr/master/68a88c57
branch
from
e300a56 to
d0a3767
Compare
progwriter
left a comment
progwriter
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dhalperi)
projects/batfish-common-protocol/src/main/java/org/batfish/vendor/VendorConfiguration.java line 0 at r1 (raw file):
Previously, dhalperi (Dan Halperin) wrote…
(Reviewable was unable to map this GitHub inline comment thread to the right spot — sorry!)
Q: how much does this
.distinct()matter. Having a hard time finding a benchmark that would have invoked it.
I was going to ask the same question :)
dhalperi
left a comment
dhalperi
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @dhalperi)
projects/batfish-common-protocol/src/main/java/org/batfish/vendor/VendorConfiguration.java line 0 at r1 (raw file):
Previously, progwriter (Victor Heorhiadi) wrote…
I was going to ask the same question :)
https://github.com/batfish/batfish/pull/6249/files says I introduced this, so I say not much
All these streams are slow. commit-id:68a88c57
dhalperi
force-pushed
the
spr/master/68a88c57
branch
from
d0a3767 to
c44e26a
Compare
dhalperi
left a comment
dhalperi
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:
3 participants
All these streams are slow.