Junos: parse and warn on empty interface description

[0x-0ddc0de]

The prevents crashing when interface description is empty. Junos will ignore an interface statement with an empty description (ie the statement has no effect).

[batfish-bot]

This change is 

[codecov]

Codecov Report

Merging #8972 (2d73c10) into master (c943c1b) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #8972   +/-   ##
=======================================
  Coverage   72.51%   72.51%           
=======================================
  Files        3323     3323           
  Lines      169630   169630           
  Branches    19914    19914           
=======================================
+ Hits       123004   123010    +6     
+ Misses      37462    37455    -7     
- Partials     9164     9165    +1     

see 3 files with indirect coverage changes

[dhalperi]

Reviewed all commit messages.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @zergling-aws)

---

projects/batfish/src/main/java/org/batfish/grammar/flatjuniper/ConfigurationBuilder.java line 4929 at r1 (raw file):

    } catch (NullPointerException e) {
      warn(ctx, "Batfish does not support an empty description");
    }

The better way to do this would be to check for null.

if (ctx.description() == null) {
   warn...
} else {
    setDesc...
}

But I wonder -- why accept description missing vs just not parse it?

Code quote:

    try {
      String text = toString(ctx.description());
      _currentInterfaceOrRange.setDescription(text);
    } catch (NullPointerException e) {
      warn(ctx, "Batfish does not support an empty description");
    }

[dhalperi]

Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @zergling-aws)