Junos: convert last F_DecByte to F_Uint8#9008
Merged
Conversation
Juniper allows leading 0s in numbers, generally, including IP addresses. We already handle this in F_Uint8, but somehow we had a nearly-equivalent F_DecByte that was only used in IP address that did not allow zeros. Fix this last case, add a test, and delete the now unused fragment. commit-id:ad6f606b
|
This change is |
Contributor
anothermattbrown
left a comment
anothermattbrown
left a comment
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @dhalperi)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Juniper allows leading 0s in numbers, generally, including IP addresses. We already handle
this in F_Uint8, but somehow we had a nearly-equivalent F_DecByte that was only used
in IP address that did not allow zeros. Fix this last case, add a test, and delete
the now unused fragment.