Skip to content

Batfish: include question name and runtime in answer completion logs#9150

Merged
dhalperi merged 1 commit intomasterfrom
spr/master/9b78a41c
Aug 8, 2024
Merged

Batfish: include question name and runtime in answer completion logs#9150
dhalperi merged 1 commit intomasterfrom
spr/master/9b78a41c

Conversation

@dhalperi
Copy link
Copy Markdown
Member

@dhalperi dhalperi commented Aug 8, 2024

No description provided.

@batfish-bot
Copy link
Copy Markdown

This change is Reviewable

@dhalperi dhalperi changed the title Batfish: include question name in failure logs Batfish: include question name and runtime in answer completion logs Aug 8, 2024
@dhalperi dhalperi force-pushed the spr/master/9b78a41c branch from 5c1fda1 to 8626a46 Compare August 8, 2024 17:08
@dhalperi dhalperi enabled auto-merge (squash) August 8, 2024 17:09
Copy link
Copy Markdown
Contributor

@SLarkworthy SLarkworthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @progwriter)

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 72.68%. Comparing base (811b231) to head (8626a46).
Report is 79 commits behind head on master.

Files with missing lines Patch % Lines
...atfish/src/main/java/org/batfish/main/Batfish.java 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9150      +/-   ##
==========================================
- Coverage   72.69%   72.68%   -0.02%     
==========================================
  Files        3314     3314              
  Lines      169785   169790       +5     
  Branches    19982    19982              
==========================================
- Hits       123431   123412      -19     
- Misses      37195    37216      +21     
- Partials     9159     9162       +3     
Files with missing lines Coverage Δ
...atfish/src/main/java/org/batfish/main/Batfish.java 68.90% <0.00%> (-0.23%) ⬇️

... and 5 files with indirect coverage changes

@dhalperi dhalperi merged commit 9d94185 into master Aug 8, 2024
@dhalperi dhalperi deleted the spr/master/9b78a41c branch August 8, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants