Junos: reduce blast radius of missing quote in hierarchical configs#9172
Merged
Junos: reduce blast radius of missing quote in hierarchical configs#9172
Conversation
Junos requires quoted strings to be on one line anyway, as far as I can tell online and in configs. commit-id:00c99d84
arifogel
reviewed
Aug 23, 2024
Member
arifogel
left a comment
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @dhalperi)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9172 +/- ##
==========================================
- Coverage 72.71% 72.70% -0.02%
==========================================
Files 3313 3313
Lines 169906 169906
Branches 20013 20013
==========================================
- Hits 123549 123526 -23
- Misses 37196 37215 +19
- Partials 9161 9165 +4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Junos requires quoted strings to be on one line anyway, as far as I can tell online and in configs.