Skip to content

Junos: reduce blast radius of missing quote in hierarchical configs#9172

Merged
dhalperi merged 1 commit intomasterfrom
spr/master/00c99d84
Aug 23, 2024
Merged

Junos: reduce blast radius of missing quote in hierarchical configs#9172
dhalperi merged 1 commit intomasterfrom
spr/master/00c99d84

Conversation

@dhalperi
Copy link
Copy Markdown
Member

Junos requires quoted strings to be on one line anyway, as far as I can tell online and in configs.

Junos requires quoted strings to be on one line anyway, as far as I can tell online and in configs.

commit-id:00c99d84
@batfish-bot
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Member

@arifogel arifogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dhalperi)

@dhalperi dhalperi enabled auto-merge (squash) August 23, 2024 06:10
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.70%. Comparing base (a4825c3) to head (598ef7b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9172      +/-   ##
==========================================
- Coverage   72.71%   72.70%   -0.02%     
==========================================
  Files        3313     3313              
  Lines      169906   169906              
  Branches    20013    20013              
==========================================
- Hits       123549   123526      -23     
- Misses      37196    37215      +19     
- Partials     9161     9165       +4     

see 7 files with indirect coverage changes

@dhalperi dhalperi merged commit c6a4658 into master Aug 23, 2024
@dhalperi dhalperi deleted the spr/master/00c99d84 branch August 23, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants