Skip to content

NX-OS: add missing reference tracking for snmp-server user use-ipv[46]acl#9184

Merged
dhalperi merged 1 commit intomasterfrom
spr/master/baaa829a
Aug 30, 2024
Merged

NX-OS: add missing reference tracking for snmp-server user use-ipv[46]acl#9184
dhalperi merged 1 commit intomasterfrom
spr/master/baaa829a

Conversation

@dhalperi
Copy link
Copy Markdown
Member

@dhalperi dhalperi commented Aug 30, 2024

@batfish-bot
Copy link
Copy Markdown

This change is Reviewable

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.

Project coverage is 72.71%. Comparing base (cfd090b) to head (f2055fc).
Report is 44 commits behind head on master.

Files with missing lines Patch % Lines
...mar/cisco_nxos/CiscoNxosControlPlaneExtractor.java 66.66% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9184   +/-   ##
=======================================
  Coverage   72.71%   72.71%           
=======================================
  Files        3313     3313           
  Lines      169928   169942   +14     
  Branches    20016    20018    +2     
=======================================
+ Hits       123560   123577   +17     
+ Misses      37205    37200    -5     
- Partials     9163     9165    +2     
Files with missing lines Coverage Δ
...esentation/cisco_nxos/CiscoNxosStructureUsage.java 100.00% <100.00%> (ø)
...mar/cisco_nxos/CiscoNxosControlPlaneExtractor.java 78.81% <66.66%> (-0.04%) ⬇️

... and 2 files with indirect coverage changes

@dhalperi dhalperi force-pushed the spr/master/baaa829a branch from ed978a4 to d93078b Compare August 30, 2024 16:53
@dhalperi dhalperi force-pushed the spr/master/270130ad branch from 6afcf5a to 2a54c11 Compare August 30, 2024 16:53
@dhalperi dhalperi force-pushed the spr/master/baaa829a branch from d93078b to 03b57c3 Compare August 30, 2024 16:54
Base automatically changed from spr/master/270130ad to master August 30, 2024 16:54
@dhalperi dhalperi force-pushed the spr/master/baaa829a branch from 03b57c3 to f2055fc Compare August 30, 2024 16:54
Copy link
Copy Markdown
Contributor

@progwriter progwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @arifogel and @SLarkworthy)

@dhalperi dhalperi enabled auto-merge (squash) August 30, 2024 16:57
@dhalperi dhalperi merged commit eefe9a1 into master Aug 30, 2024
@dhalperi dhalperi deleted the spr/master/baaa829a branch August 30, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cisco ip access-list flagged as Unused Structure in snmp-server configuration

3 participants