Batfish: disable parse reuse by default#9214
Merged
Conversation
When we added this feature, Batfish parsers were ridiculously slow and this made a big difference. However, after we did a number of improvements to make the parsers LL1 and in general use modes better and crappy ambiguous grammar rules less, the parsers sped up dramatically. At this point, the reparsing is often faster than deserializing prior results, and it uses less I/O. Refs: * Adding parse reuse in 2019: #3070 * grammar improvements, e.g., #8268 * and this big blank line one: #6778 commit-id:5ff7f471
progwriter
reviewed
Sep 17, 2024
Contributor
progwriter
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @arifogel)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9214 +/- ##
==========================================
- Coverage 78.16% 78.14% -0.03%
==========================================
Files 3314 3314
Lines 170021 170021
Branches 20049 20049
==========================================
- Hits 132899 132860 -39
- Misses 37122 37161 +39
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we added this feature, Batfish parsers were ridiculously slow and this
made a big difference. However, after we did a number of improvements to make
the parsers LL1 and in general use modes better and crappy ambiguous grammar
rules less, the parsers sped up dramatically. At this point, the reparsing is
often faster than deserializing prior results, and it uses less I/O.
Refs: