Skip to content

Batfish: disable parse reuse by default#9214

Merged
dhalperi merged 1 commit intomasterfrom
spr/master/5ff7f471
Sep 17, 2024
Merged

Batfish: disable parse reuse by default#9214
dhalperi merged 1 commit intomasterfrom
spr/master/5ff7f471

Conversation

@dhalperi
Copy link
Copy Markdown
Member

When we added this feature, Batfish parsers were ridiculously slow and this
made a big difference. However, after we did a number of improvements to make
the parsers LL1 and in general use modes better and crappy ambiguous grammar
rules less, the parsers sped up dramatically. At this point, the reparsing is
often faster than deserializing prior results, and it uses less I/O.

Refs:

When we added this feature, Batfish parsers were ridiculously slow and this
made a big difference. However, after we did a number of improvements to make
the parsers LL1 and in general use modes better and crappy ambiguous grammar
rules less, the parsers sped up dramatically. At this point, the reparsing is
often faster than deserializing prior results, and it uses less I/O.

Refs:
* Adding parse reuse in 2019: #3070
* grammar improvements, e.g., #8268
* and this big blank line one: #6778

commit-id:5ff7f471
@batfish-bot
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Contributor

@progwriter progwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @arifogel)

@dhalperi dhalperi merged commit 9b53cd0 into master Sep 17, 2024
@dhalperi dhalperi deleted the spr/master/5ff7f471 branch September 17, 2024 16:26
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.14%. Comparing base (0edf444) to head (4fc5aa6).
Report is 46 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9214      +/-   ##
==========================================
- Coverage   78.16%   78.14%   -0.03%     
==========================================
  Files        3314     3314              
  Lines      170021   170021              
  Branches    20049    20049              
==========================================
- Hits       132899   132860      -39     
- Misses      37122    37161      +39     
Files with missing lines Coverage Δ
...ish/src/main/java/org/batfish/config/Settings.java 85.43% <100.00%> (-0.33%) ⬇️

... and 4 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants