IPv6: fix toString

[dhalperi]

Stack:

• Ip6: remove unused AUTO #9248
• Ip6: delete unused getAddressBits and the scary (unbounded) cache it has #9247
• IPv6: fix toString #9246 ⬅

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

[batfish-bot]

This change is 

[dhalperi]

Reviewable status: 0 of 9 files reviewed, all discussions resolved (waiting on @SLarkworthy)

---

projects/batfish-common-protocol/src/main/java/org/batfish/datamodel/Ip6.java line 50 at r1 (raw file):

      remainder = remainder.shiftRight(16);
    }

I feel like this should be simplifiable, but you know it wasn't easy to see how.

[codecov]

Codecov Report

Attention: Patch coverage is 96.55172% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.73%. Comparing base (fce5773) to head (6260fc3).
Report is 46 commits behind head on master.

Files with missing lines	Patch %	Lines
...tocol/src/main/java/org/batfish/datamodel/Ip6.java	96.55%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #9246   +/-   ##
=======================================
  Coverage   72.72%   72.73%           
=======================================
  Files        3316     3316           
  Lines      170084   170107   +23     
  Branches    20051    20061   +10     
=======================================
+ Hits       123702   123735   +33     
+ Misses      37216    37207    -9     
+ Partials     9166     9165    -1     

Files with missing lines	Coverage Δ
...tocol/src/main/java/org/batfish/datamodel/Ip6.java	80.89% <96.55%> (+5.14%)	⬆️

... and 7 files with indirect coverage changes

[SLarkworthy]

Reviewable status: 0 of 9 files reviewed, 1 unresolved discussion (waiting on @dhalperi)

---

projects/batfish-common-protocol/src/main/java/org/batfish/datamodel/Ip6.java line 78 at r1 (raw file):

    }

    // Handle edge case where the longest sequence is at the end

Can just move this check to right after you append currentLength and you wouldn't need to handle this case separately.

[dhalperi]

Reviewable status: 0 of 9 files reviewed, 1 unresolved discussion (waiting on @SLarkworthy)

---

projects/batfish-common-protocol/src/main/java/org/batfish/datamodel/Ip6.java line 78 at r1 (raw file):

Previously, SLarkworthy (Sarah Larkworthy) wrote…

Can just move this check to right after you append currentLength and you wouldn't need to handle this case separately.

Done.

[SLarkworthy]

Reviewed 8 of 9 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dhalperi)