Skip to content

Support more rib names in Junos parser#9253

Merged
SLarkworthy merged 1 commit intobatfish:masterfrom
SLarkworthy:sarah-more-rib-names
Oct 22, 2024
Merged

Support more rib names in Junos parser#9253
SLarkworthy merged 1 commit intobatfish:masterfrom
SLarkworthy:sarah-more-rib-names

Conversation

@SLarkworthy
Copy link
Copy Markdown
Contributor

@SLarkworthy SLarkworthy requested a review from dhalperi October 19, 2024 00:26
@batfish-bot
Copy link
Copy Markdown

This change is Reviewable

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.73%. Comparing base (0385c13) to head (c739842).
Report is 40 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9253      +/-   ##
==========================================
- Coverage   72.74%   72.73%   -0.02%     
==========================================
  Files        3316     3316              
  Lines      170093   170093              
  Branches    20059    20059              
==========================================
- Hits       123742   123722      -20     
- Misses      37187    37202      +15     
- Partials     9164     9169       +5     

see 7 files with indirect coverage changes

Copy link
Copy Markdown
Contributor

@progwriter progwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dhalperi)


projects/batfish/src/test/java/org/batfish/grammar/flatjuniper/FlatJuniperGrammarTest.java line 6100 at r1 (raw file):

    // Just don't have parse warnings
    JuniperConfiguration c = parseJuniperConfig("routing-options-misc");
    c.getHostname();

nit: does the getHostname serve any purpose here?

@dhalperi dhalperi removed their request for review October 21, 2024 15:51
Copy link
Copy Markdown
Contributor Author

@SLarkworthy SLarkworthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 3 of 4 files reviewed, all discussions resolved (waiting on @progwriter)


projects/batfish/src/test/java/org/batfish/grammar/flatjuniper/FlatJuniperGrammarTest.java line 6100 at r1 (raw file):

Previously, progwriter (Victor Heorhiadi) wrote…

nit: does the getHostname serve any purpose here?

ah thanks - no, was using it for a debug breakpoint.

Copy link
Copy Markdown
Contributor

@progwriter progwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SLarkworthy)

@SLarkworthy SLarkworthy enabled auto-merge (squash) October 22, 2024 18:10
@SLarkworthy SLarkworthy merged commit a87f564 into batfish:master Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants