Support more rib names in Junos parser#9253
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9253 +/- ##
==========================================
- Coverage 72.74% 72.73% -0.02%
==========================================
Files 3316 3316
Lines 170093 170093
Branches 20059 20059
==========================================
- Hits 123742 123722 -20
- Misses 37187 37202 +15
- Partials 9164 9169 +5 |
progwriter
left a comment
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @dhalperi)
projects/batfish/src/test/java/org/batfish/grammar/flatjuniper/FlatJuniperGrammarTest.java line 6100 at r1 (raw file):
// Just don't have parse warnings JuniperConfiguration c = parseJuniperConfig("routing-options-misc"); c.getHostname();
nit: does the getHostname serve any purpose here?
5dc8b8f to
c739842
Compare
SLarkworthy
left a comment
There was a problem hiding this comment.
Reviewable status: 3 of 4 files reviewed, all discussions resolved (waiting on @progwriter)
projects/batfish/src/test/java/org/batfish/grammar/flatjuniper/FlatJuniperGrammarTest.java line 6100 at r1 (raw file):
Previously, progwriter (Victor Heorhiadi) wrote…
nit: does the
getHostnameserve any purpose here?
ah thanks - no, was using it for a debug breakpoint.
progwriter
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @SLarkworthy)
No extraction - just parsing more rib names in Junos:
rib bgp.l2vpn.0
rib bgp.l3vpn-inet6.0
rib bgp.l3vpn.0
rib :vxlan.inet.0
https://www.juniper.net/documentation/us/en/software/junos/static-routing/topics/topic-map/config_junos_routing_table.html#id-example-exporting-specific-routes-from-one-routing-table-into-another-routing-table