Skip to content

AclLineMatchExprs: redo and and or helpers#9270

Merged
dhalperi merged 1 commit intomasterfrom
spr/master/c0460b9f
Nov 12, 2024
Merged

AclLineMatchExprs: redo and and or helpers#9270
dhalperi merged 1 commit intomasterfrom
spr/master/c0460b9f

Conversation

@dhalperi
Copy link
Copy Markdown
Member

@dhalperi dhalperi commented Nov 12, 2024

No description provided.

@batfish-bot
Copy link
Copy Markdown

This change is Reviewable

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.73%. Comparing base (97de487) to head (fcb9bc8).
Report is 33 commits behind head on master.

Files with missing lines Patch % Lines
...a/org/batfish/datamodel/acl/AclLineMatchExprs.java 88.88% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9270      +/-   ##
==========================================
- Coverage   72.74%   72.73%   -0.01%     
==========================================
  Files        3315     3315              
  Lines      170034   170032       -2     
  Branches    20059    20059              
==========================================
- Hits       123683   123673      -10     
- Misses      37187    37191       +4     
- Partials     9164     9168       +4     
Files with missing lines Coverage Δ
...heck_point_management/AddressSpaceToMatchExpr.java 100.00% <100.00%> (ø)
...dor/check_point_management/ServiceToMatchExpr.java 95.34% <100.00%> (ø)
...a/org/batfish/datamodel/acl/AclLineMatchExprs.java 85.00% <88.88%> (-1.62%) ⬇️

... and 3 files with indirect coverage changes

@dhalperi dhalperi enabled auto-merge (squash) November 12, 2024 07:35
Copy link
Copy Markdown
Member Author

@dhalperi dhalperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dhalperi)

@dhalperi dhalperi merged commit 980165c into master Nov 12, 2024
@dhalperi dhalperi deleted the spr/master/c0460b9f branch November 12, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants