Junos: family-aware firewall filter reference tracking for family inet6#9290
Merged
Junos: family-aware firewall filter reference tracking for family inet6#9290
Conversation
50f1a37 to
5d9dee4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9290 +/- ##
==========================================
- Coverage 72.75% 72.74% -0.02%
==========================================
Files 3321 3321
Lines 170242 170248 +6
Branches 20080 20081 +1
==========================================
- Hits 123863 123847 -16
- Misses 37206 37225 +19
- Partials 9173 9176 +3
|
In the process I removed null_filler that was hiding sins, and then I had to add (and mildly fixup) mtu. commit-id:a5d975fd
5d9dee4 to
dd4d94d
Compare
progwriter
reviewed
Nov 21, 2024
Contributor
progwriter
left a comment
There was a problem hiding this comment.
Reviewed 3 of 5 files at r1, 5 of 5 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @dhalperi)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the process I removed null_filler that was hiding sins, and then
I had to add (and mildly fixup) mtu.