Skip to content

Junos: family-aware firewall filter reference tracking for family inet6#9290

Merged
dhalperi merged 1 commit intomasterfrom
spr/master/a5d975fd
Nov 21, 2024
Merged

Junos: family-aware firewall filter reference tracking for family inet6#9290
dhalperi merged 1 commit intomasterfrom
spr/master/a5d975fd

Conversation

@dhalperi
Copy link
Copy Markdown
Member

@dhalperi dhalperi commented Nov 21, 2024

In the process I removed null_filler that was hiding sins, and then
I had to add (and mildly fixup) mtu.

@batfish-bot
Copy link
Copy Markdown

This change is Reviewable

@dhalperi dhalperi force-pushed the spr/master/a5d975fd branch from 50f1a37 to 5d9dee4 Compare November 21, 2024 16:33
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 72.74%. Comparing base (d1116e0) to head (dd4d94d).
Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
...fish/grammar/flatjuniper/ConfigurationBuilder.java 42.85% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9290      +/-   ##
==========================================
- Coverage   72.75%   72.74%   -0.02%     
==========================================
  Files        3321     3321              
  Lines      170242   170248       +6     
  Branches    20080    20081       +1     
==========================================
- Hits       123863   123847      -16     
- Misses      37206    37225      +19     
- Partials     9173     9176       +3     
Files with missing lines Coverage Δ
...h/representation/juniper/JuniperStructureType.java 100.00% <100.00%> (ø)
...fish/grammar/flatjuniper/ConfigurationBuilder.java 69.46% <42.85%> (-0.06%) ⬇️

... and 6 files with indirect coverage changes

In the process I removed null_filler that was hiding sins, and then
I had to add (and mildly fixup) mtu.

commit-id:a5d975fd
@dhalperi dhalperi force-pushed the spr/master/a5d975fd branch from 5d9dee4 to dd4d94d Compare November 21, 2024 16:55
Copy link
Copy Markdown
Contributor

@progwriter progwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 5 files at r1, 5 of 5 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dhalperi)

@dhalperi dhalperi enabled auto-merge (squash) November 21, 2024 16:59
@dhalperi dhalperi merged commit b68accb into master Nov 21, 2024
@dhalperi dhalperi deleted the spr/master/a5d975fd branch November 21, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants