Junos: parse if-route-exists ip address#9353
Conversation
SLarkworthy
left a comment
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @SirasornT)
SLarkworthy
left a comment
There was a problem hiding this comment.
Actually, can you add an extraction test as well? That these are extracted with the /32, /128?
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @SirasornT)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9353 +/- ##
==========================================
- Coverage 73.17% 73.16% -0.02%
==========================================
Files 3321 3321
Lines 169206 169206
Branches 20112 20112
==========================================
- Hits 123812 123794 -18
- Misses 36288 36302 +14
- Partials 9106 9110 +4 🚀 New features to boost your workflow:
|
SLarkworthy
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @SirasornT)
This PR modifies the Junos parser grammar so that
if-route-existscan parse IPv4 and IPv6 addresses, following the documentation https://www.juniper.net/documentation/us/en/software/junos/cli-reference/topics/ref/statement/if-route-exists-edit-policy-options-condition.html.The test file uses IPv4 and IPv6 prefix reserved for documentation and testing (RFC5737 and RFC3849)