Skip to content

Junos: parse if-route-exists ip address#9353

Merged
progwriter merged 2 commits intobatfish:masterfrom
SirasornT:if-route-exist-ip-input
Mar 13, 2025
Merged

Junos: parse if-route-exists ip address#9353
progwriter merged 2 commits intobatfish:masterfrom
SirasornT:if-route-exist-ip-input

Conversation

@SirasornT
Copy link
Copy Markdown
Contributor

This PR modifies the Junos parser grammar so that if-route-exists can parse IPv4 and IPv6 addresses, following the documentation https://www.juniper.net/documentation/us/en/software/junos/cli-reference/topics/ref/statement/if-route-exists-edit-policy-options-condition.html.

The test file uses IPv4 and IPv6 prefix reserved for documentation and testing (RFC5737 and RFC3849)

@batfish-bot
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Contributor

@SLarkworthy SLarkworthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SirasornT)

Copy link
Copy Markdown
Contributor

@SLarkworthy SLarkworthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, can you add an extraction test as well? That these are extracted with the /32, /128?

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SirasornT)

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.16%. Comparing base (ae33bc8) to head (21be114).
Report is 52 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9353      +/-   ##
==========================================
- Coverage   73.17%   73.16%   -0.02%     
==========================================
  Files        3321     3321              
  Lines      169206   169206              
  Branches    20112    20112              
==========================================
- Hits       123812   123794      -18     
- Misses      36288    36302      +14     
- Partials     9106     9110       +4     

see 10 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@SLarkworthy SLarkworthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SirasornT)

@progwriter progwriter merged commit 1447281 into batfish:master Mar 13, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants