Skip to content

ExtendedCommunity: fix case awareness#9362

Merged
dhalperi merged 1 commit intomasterfrom
spr/master/46224cfe
Mar 21, 2025
Merged

ExtendedCommunity: fix case awareness#9362
dhalperi merged 1 commit intomasterfrom
spr/master/46224cfe

Conversation

@dhalperi
Copy link
Copy Markdown
Member

@dhalperi dhalperi commented Mar 20, 2025

Move lowercase to the top and add a test that failed before.


Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

Move lowercase to the top and add a test that failed before.

commit-id:46224cfe
@batfish-bot
Copy link
Copy Markdown

This change is Reviewable

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.16%. Comparing base (1e04822) to head (aa8465d).
Report is 45 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9362      +/-   ##
==========================================
- Coverage   73.17%   73.16%   -0.01%     
==========================================
  Files        3321     3321              
  Lines      169222   169222              
  Branches    20118    20118              
==========================================
- Hits       123823   123807      -16     
- Misses      36291    36305      +14     
- Partials     9108     9110       +2     
Files with missing lines Coverage Δ
...ish/datamodel/bgp/community/ExtendedCommunity.java 83.09% <100.00%> (ø)

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member Author

@dhalperi dhalperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mention @SirasornT

Reviewable status: 0 of 2 files reviewed, all discussions resolved

@dhalperi dhalperi enabled auto-merge (squash) March 21, 2025 00:30
Copy link
Copy Markdown
Contributor

@SirasornT SirasornT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @dhalperi)

Copy link
Copy Markdown
Contributor

@SirasornT SirasornT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dhalperi)

@dhalperi dhalperi merged commit 1883c09 into master Mar 21, 2025
8 checks passed
@dhalperi dhalperi deleted the spr/master/46224cfe branch March 21, 2025 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants