Fix reusable workflow to checkout lab-validation repository#82
Merged
Conversation
The reusable workflow was checking out the calling repository instead of the lab-validation repository, causing the discover-labs job to fail when trying to find the snapshots/ directory. Fixes both checkout actions: - discover-labs: Add repository: batfish/lab-validation - lab-integration-test: Add repository: batfish/lab-validation to existing path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The reusable workflow was checking out the calling repository instead of the lab-validation repository, causing the discover-labs job to fail when trying to find the snapshots/ directory.
When called from batfish/docker, the workflow would check out the docker repository and then try to run:
ls -1 snapshots/ # This fails because docker repo has no snapshots/ directorySolution
Fixed both checkout actions to explicitly specify the lab-validation repository:
repository: batfish/lab-validationrepository: batfish/lab-validationto the existing path specificationImpact
This enables the reusable workflow to be called from any repository (like batfish/docker) while still accessing the lab snapshots and test framework from lab-validation.
Testing
This fix is needed for batfish/docker#140 which integrates lab-validation testing into the docker release pipeline.