Move question answer logic into Session.answer_question()#975
Merged
Move question answer logic into Session.answer_question()#975
Conversation
dhalperi
commented
Apr 6, 2026
Member
Author
dhalperi
left a comment
There was a problem hiding this comment.
@dhalperi reviewed 3 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on dhalperi).
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #975 +/- ##
==========================================
- Coverage 87.80% 87.79% -0.02%
==========================================
Files 26 26
Lines 3773 3769 -4
Branches 503 503
==========================================
- Hits 3313 3309 -4
Misses 330 330
Partials 130 130
🚀 New features to boost your workflow:
|
QuestionBase.answer() previously called _bf_answer_obj(), a free function in internal.py that directly invoked restv2helper and workhelper, bypassing the session. This made it impossible for Session subclasses to override question answering behavior. Move that logic into Session.answer_question() and have QuestionBase.answer() call it via self._session. Remove the now-unused _bf_answer_obj() function. ---- Prompt: ``` Make session.q(params).answer() call back into session so that subclasses can override the question answer transport. ``` commit-id:fa22b8a7
2e00e84 to
a0c1398
Compare
dhalperi
commented
Apr 6, 2026
Member
Author
dhalperi
left a comment
There was a problem hiding this comment.
@dhalperi reviewed 1 file and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on dhalperi).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QuestionBase.answer() previously called _bf_answer_obj(), a free function in internal.py that directly invoked restv2helper and workhelper, bypassing the session. This made it impossible for Session subclasses to override question answering behavior.
Move that logic into Session.answer_question() and have QuestionBase.answer() call it via self._session. Remove the now-unused _bf_answer_obj() function.
Prompt:
commit-id:fa22b8a7