Add warning about "missing" parts of regex #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As someone new to bash, but familiar with regular expressions, it wasn't clear to me that something like \w would not work. This added admonition should hopefully save future on-lookers the same trouble I experienced.
brokenpip3
approved these changes
Nov 11, 2024
brokenpip3
approved these changes
Feb 26, 2025
Author
|
I came here to merge this after seeing the recent approval, but I realized once I got here that someone with write access may need to leave a review to allow the merge. At least that's the sense I get from this: |
martin-schulze-vireso
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As someone new to bash, but familiar with regular expressions, it wasn't clear to me that something like
\wwould not work. This added admonition should hopefully save future on-lookers the same trouble I experienced.I used the wording from the S/O response that helped me realize my error, but if you'd like to change it, that's fine by me.