Conversation
Contributor
|
Looks good. You might want to make the Math / StrictMath method calls cheaper. |
|
Another clarification request: a number of competitors have gotten confused about sentences like "If -1 is passed, robots from the whole map are returned" in the sensor methods. They think that senseNearbyRobots(-1) will actually see the whole map, regardless of sight range. Would be good to clarify that regardless of the range specified, you are still constrained by your vision radius. |
added 2 commits
January 9, 2017 17:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Javadoc is nicer now