Skip to content

Conversation

@rez1dent3
Copy link
Member

@rez1dent3 rez1dent3 commented Nov 1, 2021

In the 7th version, I want to work on the performance of the package and fix the crooked work with the basket (a lot of insert requests are generated by the package).

I would like to add partial work with UUID. It won't be a Primary Key, but it's not bad either. It is currently not possible to use the package asynchronously and this architectural change should make your API as fast as possible.

@rez1dent3 rez1dent3 self-assigned this Nov 1, 2021
@codecov
Copy link

codecov bot commented Nov 1, 2021

Codecov Report

Merging #390 (31558a7) into master (fd63cc4) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##              master      #390   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       293       300    +7     
===========================================
  Files             37        46    +9     
  Lines            982      1024   +42     
===========================================
+ Hits             982      1024   +42     
Impacted Files Coverage Δ
src/Internal/Dto/AvailabilityDto.php 100.00% <ø> (ø)
src/Internal/Dto/BasketDto.php 100.00% <ø> (ø)
src/Internal/Dto/ItemDto.php 100.00% <ø> (ø)
src/Models/Transaction.php 100.00% <ø> (ø)
src/Models/Transfer.php 100.00% <ø> (ø)
src/Services/PurchaseService.php 100.00% <ø> (ø)
src/Traits/CanPay.php 100.00% <ø> (ø)
src/Internal/Assembler/TransactionDtoAssembler.php 100.00% <100.00%> (ø)
src/Internal/Assembler/TransferDtoAssembler.php 100.00% <100.00%> (ø)
src/Internal/Dto/TransactionDto.php 100.00% <100.00%> (ø)
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd63cc4...31558a7. Read the comment docs.

@rez1dent3
Copy link
Member Author

Let's sum up the results of the work. Already, most of the requests are optimized, for example, payFree does not update the balance and storage.

Transactions are disabled now, but I will definitely return them to the release.

A lot of code has been corrected and rewritten. I hope this work will not be lost like the previous one. Enjoy version 6.2 and wait for 7.x. Thank you all for your support.

@rez1dent3
Copy link
Member Author

Memcached support will end here, apparently. I will try to make an architectural change to improve the situation, but it will hardly work.

@rez1dent3 rez1dent3 merged commit 31558a7 into master Nov 11, 2021
@rez1dent3 rez1dent3 mentioned this pull request Nov 11, 2021
@rez1dent3
Copy link
Member Author

The wrong branch went to the master ... I had to roll it back. Pull request has been moved to #407

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

7.x-dev bug Something isn't working enhancement New feature or request performance requires testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant