Skip to content

Conversation

@rez1dent3
Copy link
Member

@rez1dent3 rez1dent3 commented Nov 11, 2021

In the 7th version, I want to work on the performance of the package and fix the crooked work with the basket (a lot of insert requests are generated by the package).

I would like to add partial work with UUID. It won't be a Primary Key, but it's not bad either. It is currently not possible to use the package asynchronously and this architectural change should make your API as fast as possible.


Let's sum up the results of the work. Already, most of the requests are optimized, for example, payFree does not update the balance and storage.

Transactions are disabled now, but I will definitely return them to the release.

A lot of code has been corrected and rewritten. I hope this work will not be lost like the previous one. Enjoy version 6.2 and wait for 7.x. Thank you all for your support.

#390


deptracU68YGe

@rez1dent3 rez1dent3 added bug Something isn't working enhancement New feature or request requires testing 7.x-dev performance labels Nov 11, 2021
@rez1dent3 rez1dent3 self-assigned this Nov 11, 2021
@rez1dent3 rez1dent3 mentioned this pull request Nov 11, 2021
@codecov
Copy link

codecov bot commented Nov 11, 2021

Codecov Report

Merging #407 (b59f7f8) into master (e3e9eaf) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##              master      #407    +/-   ##
============================================
  Coverage     100.00%   100.00%            
- Complexity       293       320    +27     
============================================
  Files             37        54    +17     
  Lines            982      1117   +135     
============================================
+ Hits             982      1117   +135     
Impacted Files Coverage Δ
src/Internal/Service/UuidFactoryService.php 100.00% <ø> (ø)
src/Models/Transfer.php 100.00% <ø> (ø)
src/Services/MetaServiceLegacy.php 100.00% <ø> (ø)
src/Traits/CanPay.php 100.00% <ø> (ø)
...rc/Internal/Assembler/AvailabilityDtoAssembler.php 100.00% <100.00%> (ø)
src/Internal/Assembler/TransactionDtoAssembler.php 100.00% <100.00%> (ø)
...c/Internal/Assembler/TransactionQueryAssembler.php 100.00% <100.00%> (ø)
src/Internal/Assembler/TransferDtoAssembler.php 100.00% <100.00%> (ø)
...rc/Internal/Assembler/TransferLazyDtoAssembler.php 100.00% <100.00%> (ø)
src/Internal/Assembler/TransferQueryAssembler.php 100.00% <100.00%> (ø)
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3e9eaf...b59f7f8. Read the comment docs.

@rez1dent3
Copy link
Member Author

There is one theory ... if you close the models behind the interface, then mongodb lovers can easily integrate the database into the project. I'll try to test this theory and come back to the 7.x release.

@rez1dent3
Copy link
Member Author

No, mongodb lovers will have to wait. Definitely not in this release.

Here you can find the best practices: 66999a2

@rez1dent3
Copy link
Member Author

rez1dent3 commented Nov 18, 2021

Yesterday I made a mini benchmark of version 6.x versus 7.x .. The results are not very good, you need to make edits for single requests (deposit, withdraw, transfer, exchange). Average productivity drawdown 11%. In the near future I will make changes to the architecture.

It turns out that people are already using beta 7.x in new product development. They trust me. So, people are asking to replace the uuid type with a binary (16). Honestly, I thought about it and it needs to be tested. I'll try to come up with something and accomplish my goal based on the result.

Thank you for your feedback.

@rez1dent3
Copy link
Member Author

Binary guides can be made, but definitely not in this release. Extremely difficult transition.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Nov 25, 2021

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: b59f7f8
Status: ✅  Deploy successful!
Preview URL: https://5dcd7d8e.laravel-wallet.pages.dev

View logs

@rez1dent3 rez1dent3 merged commit 77b781e into master Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

7.x-dev bug Something isn't working enhancement New feature or request performance requires testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant