Docs: clarify installation instructions for v2 #387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanradev93
previously requested changes
Apr 4, 2025
Contributor
stefanradev93
left a comment
stefanradev93
left a comment
There was a problem hiding this comment.
Thanks, Valentin! Can you change PyPi to PyPI before I merge?
vpratz
force-pushed
the
fix-installation-v2
branch
from
1d93f0c to
8097552
Compare
Collaborator
Author
|
Done, good catch, thanks for reviewing :) |
vpratz
requested review from
stefanradev93
and removed request for
paul-buerkner
Collaborator
Author
|
Bumping this. It is ready to merge, but I need your approval, @stefanradev93. Thanks in advance :) |
LarsKue
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #386.
Our installation instructions feature
pip install bayesflow, which is not in place yet for version 2. This PR adds the respective comments. This might lead to slight confusion, as in the README we basically install from source in both sections, but I think this is ok for now. If not, please make any adaptations you see fit.